make it clear to user when program exits successfully#7
Open
MareoRaft wants to merge 1 commit intosnielsen:masterfrom
Open
make it clear to user when program exits successfully#7MareoRaft wants to merge 1 commit intosnielsen:masterfrom
MareoRaft wants to merge 1 commit intosnielsen:masterfrom
Conversation
Owner
|
Something like that will indicate whether the bundle has been injected successfully or not. However, once the bundle is injected it is hard to know if it has done it's job correctly inside of the Finder process. In FinderOverride.m:87 there is a logging statement that the bundle emits when it thinks that the function override has worked successfully. You can see it show up in Console.app. Things have changed so much since I first wrote this that I wouldn't be surprised if things weren't quite working like they used to. I wish I had the time to give it the debugging justice it needs ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this what you were looking for regarding issue #6 ?